Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Io buffer #356

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Io buffer #356

merged 3 commits into from
Jun 29, 2023

Conversation

freddieknets
Copy link
Contributor

@freddieknets freddieknets commented Jun 29, 2023 •
edited
Loading

Description

Quick PR:

  • when starting logging a record for a certain set of elements, it is not needed that these elements are of the same class, however, they need to have the same internal_record_class
  • when doing a twiss at_s (hence, when a new tracker is generated), it is built with the correct io_buffer
  • I added a test for the twiss, however, by construction it cannot fail as the error thrown in C is just a message ("Error: buffer_id mismatch!") and does not halt execution

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@giadarol giadarol changed the base branch from main to release/v0.37.2 June 29, 2023 10:42
@giadarol giadarol merged commit 53d1045 into xsuite:release/v0.37.2 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freddieknets @giadarol