Close session when seeing any session level errors #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the caller can notice it when opening new streams or via the GetDieCh, then have the opportunity to dial new sessions, or the session can enter into a weird state, see xtaci#61
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 80.25% 83.94% +3.69%
==========================================
Files 6 6
Lines 780 704 -76
==========================================
- Hits 626 591 -35
+ Misses 131 93 -38
+ Partials 23 20 -3
Continue to review full report at Codecov.
|
|
Sorry, open in the wrong repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the caller can notice it when opening new streams or via the
GetDieCh, then have the opportunity to dial new sessions, or the session
can enter into a weird state, see
#61