-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: New CSV parser #1287
base: master
Are you sure you want to change the base?
WIP: New CSV parser #1287
Conversation
Thanks for this work @marty1885! We will be reviewing this tomorrow! |
@@ -31,6 +33,9 @@ namespace xt | |||
template <class T, class A = std::allocator<T>> | |||
xcsv_tensor<T, A> load_csv(std::istream& stream); | |||
|
|||
template <class T, class A = std::allocator<T>> | |||
xcsv_tensor<T, A> read_csv(std::istream& stream); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the same method name and dispatch according to a TAG or enum, something like:
enum class csv_mode
{
fast,
strict
};
template <class T, class A = std::allocator<T>>
xcsv_tensor<T, A> load_csv(std::istream& stream, csv_mode mode = csv_mode::fast)
{
// Calls the implementation method accoriding to the value of csv_mode
}
Hi @marty1885 , Sorry for the late review. The implementation of the parser itself looks good to me (maybe we could simplify it with |
@JohanMabille Thanks. I'll change that. My main concern is in my latest comment #1280 . May you check it out? |
See #1280.