sign function #99
Merged
sign function #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since #85 was merged, this needs to be rebased on master and use the new pattern for ufuncs. |
include/xtensor/xmath.hpp
Outdated
| -> detail::get_xfunction_free_type<E> | ||
| { | ||
| using functor_type = detail::mf_type<E>; | ||
| return detail::make_xfunction((functor_type)detail::sign_impl, e.derived_cast()); |
There was a problem hiding this comment.
e.derived_cast -> std::forward<E>(e)
include/xtensor/xmath.hpp
Outdated
| { | ||
| return std::numeric_limits<T>::quiet_NaN(); | ||
| } | ||
| return x == 0 ? copysign(T(0), x) : copysign(T(1), x); |
There was a problem hiding this comment.
this is what causes the windows failure. One cannot have multiple return statements in a constexpr function. So this leaves you with
return std::isnan(x)? std::numeric_limits<T>::quiet_NaN() : (x == 0 ? copysign(T(0), x) : copysign(T(1), x));
There was a problem hiding this comment.
Is the statement about isnan required?
Would the last statement suffice?
There was a problem hiding this comment.
I was about to remove the constexpr, but I guess going with your solution will work as well.
The isnan is what numpy is doing. Not sure if required.
You can decide! ;)
|
I think that it would make sense for me to squash these few commits together while merging. |
|
Sure
…On Feb 2, 2017 12:09, "Sylvain Corlay" ***@***.***> wrote:
I think that it would make sense for me to squash these few commits
together while merging.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2BPgRMNGmyNY4eJKQVtAXA3Q1iCxsWks5rYblMgaJpZM4L0S53>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaves equivalent to numpy's sign function.