Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all does not work #307

Closed
croiuki opened this issue Oct 9, 2016 · 6 comments
Closed

Select all does not work #307

croiuki opened this issue Oct 9, 2016 · 6 comments
Labels

Comments

@croiuki
Copy link

croiuki commented Oct 9, 2016

Since 2.0 version, select all in right click menu does not work.

Details

  • Browser and browser version: Google Chrome 50.0.2661.102
  • OS version: Windown 7
  • xterm.js version: 2.0.0 / 2.0.1
@parisk parisk added the type/bug Something is misbehaving label Oct 9, 2016
@parisk
Copy link
Contributor

parisk commented Oct 9, 2016

Thanks for reporting @croiuki.

The reason this happens is because the right-click happens now on the textarea instead of the terminal element. Despite that I was not able to use "Select all" on Chrome on macOS even on tag 1.1.3.

A workaround you could use here until we fix this is selecting by dragging your mouse over the area you would like to, while keeping the left-click button pressed.

As I do not ever use "Select all", I would like to know if you would expect it to select all contents in the buffer or all terminal logs. IMO selecting the buffer makes more sense.

@croiuki
Copy link
Author

croiuki commented Oct 10, 2016

Thanks for the reply.
I just want to select contents more than current screen show, but it also does not work.

@Tyriar
Copy link
Member

Tyriar commented Oct 10, 2016

We would need something such as #207 to deal with selection beyond the current page. Not sure on whether it can be implemented without causing other issues yet though.

@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2017

Select all was implemented in #670, it doesn't work with the right click menu but cmd+a will work on macs and a Terminal.selectAll API is available for consumers to hook up manually.

@Tyriar
Copy link
Member

Tyriar commented Nov 6, 2017

Still an issue in v3
image

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2018

I'm not sure there's a way forward on fixing this in the browser, closing off as I don't see a fix but happy to be proven wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants