Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force char size measurement when devicePixelRatio changes #3243

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Force char size measurement when devicePixelRatio changes #3243

merged 1 commit into from
Feb 5, 2021

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Feb 5, 2021

Fixes microsoft/vscode#102194

Note that this._charSizeService.measure() could trigger a call to this._renderer.onCharSizeChanged() which uses the same logic as this._renderer.onDevicePixelRatioChange() underneath

jeanp413 added a commit to jeanp413/vscode that referenced this pull request Feb 5, 2021
@jeanp413
Fixes microsoft#102194
14cfb09 
Depends on xtermjs/xterm.js#3243
This was referenced Feb 5, 2021
Closed
Closed
@Tyriar Tyriar added this to the 4.11.0 milestone Feb 5, 2021
Tyriar
Tyriar approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems safe as well since ICharSizeService.onCharSizeChange only fires if they do actually differ

@Tyriar Tyriar merged commit a73fe62 into xtermjs:master Feb 5, 2021
@jeanp413 jeanp413 deleted the measure-charsize-on-devicePixelRatioChange branch February 5, 2021 19:58
This was referenced Mar 10, 2021
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

First line of terminal is clipped after zooming twice
2 participants
@jeanp413 @Tyriar