Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First line of terminal is clipped after zooming twice #102194

Closed
mjbvz opened this issue Jul 11, 2020 · 6 comments · Fixed by xtermjs/xterm.js#3243, open-amt-cloud-toolkit/sample-web-ui#91, mattborghi/Julia-Terminal-Web#59, shellhub-io/shellhub#797 or vmware-archive/octant#2161
Closed

First line of terminal is clipped after zooming twice #102194

mjbvz opened this issue Jul 11, 2020 · 6 comments · Fixed by xtermjs/xterm.js#3243, open-amt-cloud-toolkit/sample-web-ui#91, mattborghi/Julia-Terminal-Web#59, shellhub-io/shellhub#797 or vmware-archive/octant#2161
Assignees
@Tyriar @meganrogge
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member ghcs-scenario-found help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Milestone
February 2021

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 11, 2020

Issue Type: Bug

Repro

  1. With integrated terminal
  2. Zoom in twice

Bug
The first line of the terminal is clipped:

Screen Shot 2020-07-10 at 9 57 38 PM

VS Code version: Code - Insiders 1.48.0-insider (e7920dc, 2020-07-10T11:55:11.286Z)
OS version: Darwin x64 19.5.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.16GB free)
Process Argv
Screen Reader no
VM 15%
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 11, 2020 •
edited
Loading

Possibly a duplicate of #101342 (it wasn't clear to me what the problem in #101342 was)

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues labels Jul 13, 2020
@Tyriar Tyriar added this to the Backlog milestone Jul 13, 2020
@meganrogge
Copy link
Contributor

recording (27)

not seeing this.

@meganrogge
Copy link
Contributor

tried this on my personal computer (a mac) and am able to reproduce this issue.

@meganrogge meganrogge added the confirmed Issue has been confirmed by VS Code Team member label Nov 5, 2020
@Tyriar Tyriar modified the milestones: Backlog, February 2021 Jan 28, 2021
jeanp413 added a commit to jeanp413/xterm.js that referenced this issue Feb 5, 2021
@jeanp413
Fixes microsoft/vscode#102194
350f6cf
@jeanp413 jeanp413 mentioned this issue Feb 5, 2021
Merged
jeanp413 added a commit to jeanp413/vscode that referenced this issue Feb 5, 2021
@jeanp413
Fixes microsoft#102194
14cfb09 
Depends on xtermjs/xterm.js#3243
@jeanp413 jeanp413 mentioned this issue Feb 5, 2021
Closed
@jeanp413
Copy link
Contributor

jeanp413 commented Feb 5, 2021

Created a PR #115907 that depends on xtermjs/xterm.js#3243 fixing this

@Tyriar Tyriar reopened this Feb 5, 2021
@Tyriar Tyriar closed this as completed in cd725da Feb 5, 2021
@connor4312
Copy link
Member

I don't repro this in stable on my machine, can Matt or Megan verify?

@connor4312 connor4312 added the author-verification-requested Issues potentially verifiable by issue author label Feb 25, 2021
@mjbvz mjbvz added the verified Verification succeeded label Feb 26, 2021
This was referenced Mar 12, 2021
Merged
Merged
Merged
Closed
Merged
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Closed
Merged
marvinthepa pushed a commit to marvinthepa/xterm.js that referenced this issue Mar 16, 2021
@jeanp413 @marvinthepa
Fixes microsoft/vscode#102194
7dd7460
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@4.11.0-beta.3
65e4a67 
Diff: xtermjs/xterm.js@2936f80...a73fe62

Fixes microsoft#102194
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member ghcs-scenario-found help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
February 2021
6 participants
@Tyriar @connor4312 @mjbvz @jeanp413 @meganrogge and others