Remove ltr-specific CSS in favor of transparent/non-opaque. #1396
Conversation
Issue 1330: This is a proper fix after the original (b27d5bb) failed to fix the issue.
| @@ -66,7 +66,8 @@ | |||
| */ | |||
| position: absolute; | |||
| opacity: 0; | |||
| left: -9999em; | |||
| color: transparent; | |||
There was a problem hiding this comment.
Isn't the element still there though unless we reposition and it could intercept mouse presses?
There was a problem hiding this comment.
It’s got a -10 z-index … that would seem to be intended to prevent that?
There was a problem hiding this comment.
It seems like by suspicion was correct, at least for the cursor type. While running in tmux the cursor should be the default pointer but mousing over the textarea location shows a text cursor.
The mouse event appears to be redirected correctly but we should fix the hover issue.
There was a problem hiding this comment.
Perhaps a pointer-events: none in the textarea’s CSS?
There was a problem hiding this comment.
Maybe, as long as you can hover without the cursor changing and click it and the event is directed to be handled by the terminal
There was a problem hiding this comment.
@Tyriar I actually see the text cursor for the entire xterm area, even on master.
I did go ahead and push up the pointer-events: none change. I’m not sure how to reproduce the change you were seeing, but when you have a spare minute give it a look.
Thank you!
There was a problem hiding this comment.
@FGasper are you running tmux in mouse mode?
| @@ -61,12 +61,16 @@ | |||
|
|
|||
| .xterm .xterm-helper-textarea { | |||
| /* | |||
| * HACK: to fix IE's blinking cursor | |||
| * Move textarea out of the screen to the far left, so that the cursor is not visible. | |||
| * This used to fix IE's blinking cursor by moving the textarea | |||
There was a problem hiding this comment.
Did you check if it still works in IE11? I can test this if you don't have access to a machine
There was a problem hiding this comment.
Ugh, of course, it blinks … lemme play with it a bit here …
|
Looks like the master branch already has this fix (as it would fail lint now). |
Issue 1330: This is a proper fix after the original (b27d5bb) failed
to fix the issue.