Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for italic rendering #1422

Merged
merged 3 commits into from
May 1, 2018
Merged

Add support for italic rendering #1422

merged 3 commits into from
May 1, 2018

Conversation

flybayer
Copy link
Contributor

This adds support for italic rendering.

You can test it with this command:

echo -e '\x1B[3m italic \x1B[m off'

Let me know if you'd like any changes or anything else!

Related to #580

@flybayer flybayer mentioned this pull request Apr 26, 2018
2 tasks
@Tyriar
Copy link
Member

Tyriar commented May 1, 2018

This is what I see when using Hack under Ubuntu (I have Hack Italic installed):

image

@Tyriar
Copy link
Member

Tyriar commented May 1, 2018

I think the problem is the ordering when using normal as the weight before setting .font to this:

normal italic 22.5px courier-new, courier, monospace

Results in the fallback:

10px sans-serif

I'll look into fixing this.

@Tyriar
Copy link
Member

Tyriar commented May 1, 2018

Should be fixed now, just needed to rearrange the font attributes.

@Tyriar
Copy link
Member

Tyriar commented May 1, 2018

@bgw FYI I'll merge this in, conflicts should be minimal in your PR

@Tyriar Tyriar added this to the 3.4.0 milestone May 1, 2018
@Tyriar Tyriar merged commit e48b15e into xtermjs:master May 1, 2018
@flybayer flybayer deleted the italic branch May 5, 2018 00:20
@LinusU LinusU mentioned this pull request May 7, 2018
@ceoshikhar
Copy link

image
Still the italics aren't rendering for me. Any solution?

@Tyriar
Copy link
Member

Tyriar commented Apr 13, 2020

Works for me:

image

Guessing it's your font config.

@shivapoudel
Copy link

@Tyriar Help is appreciated for this Cascadia Code ticket microsoft/cascadia-code#515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants