New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm scripts crashing when using node 10+ #1847

Merged

Tyriar merged 1 commit into xtermjs:master from linrock:update-natives

Dec 24, 2018

Contributor

linrock commented Dec 19, 2018

When using node 10+, several npm scripts crash with the following:

fs.js:25
'use strict';
^

ReferenceError: internalBinding is not defined
     at fs.js:25:1

To reproduce, try running yarn when using node 10 or 11

Updating natives to version 1.1.6 fixes this


          Fix npm scripts when using node 10+

86f194a

Tyriar approved these changes

View reviewed changes

Member

Tyriar left a comment

Thanks 👍

Tyriar added this to the 3.10.0 milestone

Tyriar merged commit 272cb08 into xtermjs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet