Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text being top aligned in latest Chrome and Firefox #1859

Merged
merged 4 commits into from Jan 2, 2019

Conversation

2 participants
@Tyriar
Copy link
Member

commented Dec 23, 2018

Chrome and Firefox textBaseline behavior has always differed, see:

Plus Chrome seems to have moved to Firefox's behavior in the latest version, moving to middle should fix the problem for both.

Fixes #1858


After Firefox 64

screen shot 2018-12-23 at 10 52 54 am

After Chrome 71

screen shot 2018-12-23 at 10 50 47 am

Before Firefox 64

screen shot 2018-12-23 at 10 54 17 am

Before Chrome 71

screen shot 2018-12-23 at 10 53 51 am

@Tyriar Tyriar added this to the 3.10.0 milestone Dec 23, 2018

@Tyriar Tyriar self-assigned this Dec 23, 2018

@Tyriar Tyriar requested a review from xtermjs/core Jan 1, 2019

@jerch
Copy link
Member

left a comment

Can only test here the newer versions for firefo and chrome, both look the same now. What about the older versions, your screenshots look off by 1 pixel both for chrome and firefox. Do we need a one pixel offset correction for the older versions?

@Tyriar

This comment has been minimized.

Copy link
Member Author

commented Jan 1, 2019

@jerch I don't think we need to get them to align exactly. They're both using the browser's definition of middle which is fine.

To be clear, the before screenshots are before the PR, on those versions, not < the version.

@jerch

This comment has been minimized.

Copy link
Member

commented Jan 1, 2019

Oops, got it, yeah much better now 👍

@jerch

jerch approved these changes Jan 1, 2019

@Tyriar Tyriar closed this Jan 1, 2019

@Tyriar Tyriar reopened this Jan 1, 2019

@Tyriar Tyriar merged commit 29ff74e into xtermjs:master Jan 2, 2019

1 check passed

xtermjs.xterm.js Build #20190101.12 succeeded
Details

@Tyriar Tyriar deleted the Tyriar:baseline branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.