Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overline escaping #4540

Closed
wants to merge 1 commit into from
Closed

Fix overline escaping #4540

wants to merge 1 commit into from

Conversation

ChaseKnowlden
Copy link
Contributor

Tyriar
Tyriar reviewed May 31, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would fix anything? The &nbsp was there to ensure the overline is continuous vs a plain space in an element<span> </span>

@Tyriar
Copy link
Member

Tyriar commented May 31, 2023

Turns out that issue is due to the css file not being updated

@Tyriar Tyriar closed this May 31, 2023
@ChaseKnowlden ChaseKnowlden deleted the fix-overline branch May 31, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SGR 53 "overline" in terminal
2 participants
@ChaseKnowlden @Tyriar