Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding space between rows in docs also #109

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Adding space between rows in docs also #109

merged 2 commits into from
Nov 29, 2019

Conversation

thesoftwarephilosopher
Copy link
Contributor

(Forgot this line in the past PR, oops.)

(Forgot this line in the past PR, oops.)
css/main.scss Outdated
@@ -132,6 +132,10 @@ strong {
margin-top: 20px;
}

.docs-content tr:not(:last-child) td {
padding-bottom: 1em;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2019-11-29 at 8 39 18 AM

Maybe 0.5em and include th as well?

Screen Shot 2019-11-29 at 8 40 29 AM

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tyriar Tyriar merged commit 5c56b8d into xtermjs:master Nov 29, 2019
@thesoftwarephilosopher
Copy link
Contributor Author

This technically doesn't work because the tr with the th's in it are actually the last in the thead. I think it's probably good enough for now though, unless you'd like another PR to fix that.

@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2019

@sdegutis opps, that's what I get for not double checking that it works 😛 another PR to fix is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants