Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log level to Waiter interface (enhancement) #316

Closed
pkremens opened this issue Oct 2, 2019 · 2 comments
Closed

Add log level to Waiter interface (enhancement) #316

pkremens opened this issue Oct 2, 2019 · 2 comments
Assignees
@pkremens
Labels
enhancement

Comments

@pkremens
Copy link
Contributor

pkremens commented Oct 2, 2019

These would come handy:

new SimpleWaiter(() -> isConditionMet(), "Wait for condition to be met.", Level.DEBUG)
	.interval(100L)
	.waitFor();

https://stackoverflow.com/a/3831939
@dsimansk
Copy link
Contributor

IMO this is great idea. @pkremens would you like to implement it? :)

@pkremens
Copy link
Contributor Author

I'd really like to :), but I have no capacity to do it at the moment. I'll keep that one in my personal backlog and once I clean a table a little bit, I can look into it (no promises here). Nonetheless in case someone wants to take on it, it's free to be taken ;).

@pkremens pkremens self-assigned this Nov 1, 2019
pkremens added a commit to pkremens/xtf that referenced this issue Nov 1, 2019
@pkremens
[xtf-cz#316] Update slf4j-api version to 1.7.15
415a8ad 
This version introduces the http://www.slf4j.org/api/org/slf4j/event/Level.html
pkremens added a commit to pkremens/xtf that referenced this issue Nov 1, 2019
@pkremens
[xtf-cz#316] Extend the Waiter interface with level()
4100f03 
This will allow users to choose the severity for a reason message to be logged with
@pkremens pkremens mentioned this issue Nov 1, 2019
Merged
pkremens added a commit to pkremens/xtf that referenced this issue Nov 1, 2019
@pkremens
[xtf-cz#316] Extend the Waiter interface with level()
19223c4 
This will allow users to choose the severity for a reason message to be logged with
pkremens added a commit to pkremens/xtf that referenced this issue Nov 1, 2019
@pkremens
[xtf-cz#316] Extend the Waiter interface with level()
a0d2472 
This will allow users to choose the severity for a reason message to be logged with

The default (Level.INFO) could be changed by "xtf.waiting.log.level" property
pkremens added a commit to pkremens/xtf that referenced this issue Nov 1, 2019
@pkremens
[xtf-cz#316] Extend the Waiter interface with level()
e88eb72 
This will allow users to choose the severity for a reason message to be logged with

The default (Level.INFO) could be changed by "xtf.waiting.log.level" property
pkremens added a commit to pkremens/xtf that referenced this issue Nov 1, 2019
@pkremens
[xtf-cz#316] Extend the Waiter interface with level()
5678315 
This will allow users to choose the severity for a reason message to be logged with

The default (Level.INFO) could be changed by "xtf.waiting.log.level" property
Crumby pushed a commit that referenced this issue Nov 1, 2019
@pkremens @Crumby
[#316] Update slf4j-api version to 1.7.15
a99f171 
This version introduces the http://www.slf4j.org/api/org/slf4j/event/Level.html
Crumby pushed a commit that referenced this issue Nov 1, 2019
@pkremens @Crumby
[#316] Extend the Waiter interface with level()
2d7c54f 
This will allow users to choose the severity for a reason message to be logged with

The default (Level.INFO) could be changed by "xtf.waiting.log.level" property
@pkremens pkremens closed this as completed Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkremens pkremens

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkremens @dsimansk