Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parent] add checkstyle #108

Merged
merged 3 commits into from
Jun 28, 2018
Merged

[parent] add checkstyle #108

merged 3 commits into from
Jun 28, 2018

Conversation

dsimansk
Copy link
Contributor

Related to #104

@dsimansk dsimansk requested a review from Crumby June 28, 2018 08:53
Crumby
Crumby reviewed Jun 28, 2018
View reviewed changes
Copy link
Contributor

@Crumby Crumby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does checkstyle executes automatically or do we need to add it as callback to project settings?

checkstyle.xml Outdated

<module name="OverloadMethodsDeclarationOrder"/>

<!--<module name="AvoidStarImport"/>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this line to keep it as clear as we can.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I wanted to discuss the rule actually :) I'd prefer no star imports personally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me... Even might be a little bit annoying with Idea that automatically uses star imports. But that's configurable I believe.

@dsimansk
Copy link
Contributor Author

Does checkstyle executes automatically or do we need to add it as callback to project settings?

It'll now. I forgot to add execution part.

@dsimansk
Copy link
Contributor Author

@Crumby you can check the diff 08dabbf with removed star imports. Not so bad :)

@Crumby Crumby merged commit fd5cbf4 into xtf-cz:master Jun 28, 2018
@dsimansk dsimansk mentioned this pull request Jun 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crumby Crumby Crumby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsimansk @Crumby