Automatic checkstyle #394
Merged
Automatic checkstyle #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@mchoma @maschmid @dsimansk @Crumby hi guys, could anyone review it, please? 99% of it are formatting changes. The main change is in pom file: |
Crumby
approved these changes
Oct 1, 2020
|
Thanks, I'll merge it. In case your IDE is not having good formatting, you can use https://github.com/xtf-cz/xtf/blob/170483f2972411abfb3c97470a4a2c63e373102d/ide-config/eclipse-format.xml to configure it. I'll document it in CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically re-format code when "mvn compile" is run. It will format the code and sort all imports. No more checkstyle errors during build.
Note: I'll modify checkstyle check in GH actions to check that there are no formatting changes when trying "mvn verify" to check that formatting code was commit-ed.
Please make sure your PR meets the following requirements: