Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloaded hasBuildCompleted methode with timeout parameter #69

Conversation

olegvn88
Copy link

@olegvn88 olegvn88 commented May 2, 2018

No description provided.

@zroubalik zroubalik requested a review from maschmid May 2, 2018 13:06
@Crumby
Copy link
Contributor

Crumby commented May 2, 2018

This breaks intended way of using Waiters... The main reason is not to have a bunch of overriding methods with bunch of parameters. So if you don't like default wait timeout just call eg.: hasBuildCompleted(buildName).timeout(TimeUnit timeUnit, long timeout).execute();

@zroubalik
Copy link
Contributor

OK, seems like Waiters have a lot of hidden features. It would be very beneficial to create a documentation, with best practices, usage tip & tricks, etc.
I've created an issue for this.

@olegvn88 olegvn88 closed this May 2, 2018
@olegvn88
Copy link
Author

olegvn88 commented May 2, 2018

Thanks, I wasn't aware of that possibility

@olegvn88 olegvn88 deleted the reload_build_completion_waiter_with_timeout branch July 11, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants