Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_mac.sh cleanup #21

Merged
merged 17 commits into from
May 8, 2019
Merged

setup_mac.sh cleanup #21

merged 17 commits into from
May 8, 2019

Conversation

0xmachos
Copy link
Contributor

@0xmachos 0xmachos commented May 5, 2019

I've overhauled setup_mac.sh.

Cleaned up the executed commands, added some checks and then converted the whole script to using functions.

  • Check if directories exist before rming them
  • For brew and pip3 install packages in a loop
  • Remove installing pip & pip3, they're included with python when installed via brew
  • Change brew package from python3 to python2
    • Under brew python refers to python3
  • Check if brew is installed before running it
  • Add some set directives to enable Unofficial Bash Strict Mode

I've run these changes through shellcheck and there are no warnings or errors.

@0xmachos 0xmachos mentioned this pull request May 5, 2019
@0xmachos
Copy link
Contributor Author

0xmachos commented May 5, 2019

I've listed some of the work still to be done on issue #15 here.

@xtiankisutsa xtiankisutsa merged commit b1a778a into xtiankisutsa:master May 8, 2019
@xtiankisutsa
Copy link
Owner

Thanks for the cleanup. I'll probably use a similar approach for the mara.sh script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants