setup_mac.sh cleanup #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if directories exist before attempting to rm them.
rm -rf “${dir:?}”
This will error if variable ${dir} is empty or null.
See #15
Commented out in: 92af75f
It comes with python when installed via brew
In homebrew python = python3 See: https://docs.brew.sh/Homebrew-and-Python
Installing Yara-python via sudo -H python setup.py will create some files with root as the owner. This causes issues when chmod -R +x tools/ is run.
Closed
|
Thanks for the cleanup. I'll probably use a similar approach for the mara.sh script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've overhauled
setup_mac.sh.Cleaned up the executed commands, added some checks and then converted the whole script to using functions.
rming thembrewandpip3install packages in a looppip&pip3, they're included withpythonwhen installed viabrewbrewpackage frompython3topython2brewpythonrefers topython3brewis installed before running itsetdirectives to enable Unofficial Bash Strict ModeI've run these changes through
shellcheckand there are no warnings or errors.