Quick patch to use xtrx_open_string() instead of the removed xtrx_open_list(). #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chemeris Could you please merge this PR? |
|
Merged. Apologies for the delay I wanted a second opinion on this as I don't use gr-osmosdr myself. |
|
I can't help but notice that this pr didn't get merged into upstream with the rest of the support. Not sure if someone else is already working on that, but it would be awesome to have working support upstream. |
|
@chemeris Is it possible to do the comment above? Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to libxtrx removes the
xtrx_open_listfunction, breaking this library.This patch replaces that call with the new
xtrx_open_string.