refactor: 完成创建package.json，同时处理了一些其他小改动: (#28) #39
Conversation
|
Walkthrough这次的代码改动主要包括以下几个方面的重构：
Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (4)
- packages/@plugin/plugin-eslint/index.ts (1)
- packages/core/src/index.ts (1)
- packages/core/src/utils/createAppTest.ts (4)
- packages/core/src/utils/packageAPI.ts (1)
Files not reviewed due to errors (2)
- packages/core/src/index.ts (no response)
- packages/core/src/utils/packageAPI.ts (no response)
Files skipped from review due to trivial changes (1)
- packages/@plugin/plugin-eslint/index.ts
Review comments generated (5)
- Review: 5
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| import { projectSelect } from "./select"; | ||
| import isGitInstalled from "./checkGitInstallation"; | ||
| // import { createPackageJson } from "./createFile"; |
There was a problem hiding this comment.
这里注释掉了removeDirectory的调用，但是没有提供替代的代码。请确认是否有意为之。
| import { confirm } from "@clack/prompts"; | ||
| import chalk from "chalk"; | ||
|
|
||
| import { removeDirectory } from "./fileController"; | ||
| // import { removeDirectory } from "./fileController"; | ||
| import { projectSelect } from "./select"; | ||
| import isGitInstalled from "./checkGitInstallation"; | ||
| // import { createPackageJson } from "./createFile"; | ||
| import PackageAPI from "./packageAPI"; | ||
| import { createFiles } from "./createFiles"; | ||
| import { type Preset, getFilesForProject, getNpmForPackage } from "./preset"; | ||
| import createSuccessInfo from "./createSuccessInfo"; |
There was a problem hiding this comment.
Note: This review was outside of the patch, but no patch was found that overlapped with it. Original lines [22-23]
这里创建了一个Preset对象，但是没有使用它。请确认是否有意为之。
| console.log(shouldContinue); | ||
|
|
||
| execSync(`mkdir ${rootDirectory}`); |
There was a problem hiding this comment.
这里使用了execSync来执行命令mkdir，但是没有处理可能的异常情况。建议添加错误处理逻辑。
| const preset: Preset = await projectSelect(); | ||
|
|
||
| console.log(rootDirectory); | ||
| // 创建package.json | ||
| await createFiles(rootDirectory, { | ||
| "package.json": "{}", // todo:具体内容待重构 | ||
| console.log(chalk.blue(`\n📄 Generating package.json...`)); | ||
| const packageContent = { | ||
| name: projectName, | ||
| version: "0.1.0", | ||
| private: true, | ||
| devDependencies: {}, | ||
| }; | ||
| // 遍历 preset.plugins，插入依赖 | ||
| Object.keys(preset.plugins).forEach((dep) => { | ||
| console.log("dep:", dep); | ||
| // todo: 更多的处理依据 preset.plugins[dep] 后续的变化而插入 | ||
| let { version } = preset.plugins[dep]; | ||
| if (!version) { | ||
| version = "latest"; | ||
| } | ||
| packageContent.devDependencies[dep] = version; | ||
| }); | ||
| const packageJson = new PackageAPI(rootDirectory); | ||
| await packageJson.createPackageJson(packageContent); |
There was a problem hiding this comment.
在这个代码块中，创建了一个packageContent对象，并将其传递给PackageAPI类的createPackageJson方法。然而，在新的代码中，没有展示如何使用PackageAPI类的实例。请提供相关的代码以确保createPackageJson方法被正确调用。
| Object.keys(packageContent.devDependencies).forEach(async (dep) => { | ||
| console.log(dep, "installed"); | ||
| // 进入仓库 | ||
| // await execSync(`npm install ${plugin}`) | ||
| // await execSync(`npm install ${dep}`) |
There was a problem hiding this comment.
在这个代码块中，遍历了packageContent.devDependencies对象的键，并打印了每个键。然而，在新的代码中，没有展示如何安装依赖项。请提供相关的代码以确保依赖项被正确安装。
102:
这里打印了生成README.md文件的消息，但是没有展示具体的文件内容和创建过程。请提供相关的代码以确保README.md文件被正确创建。
以上是对packages/core/src/utils/createAppTest.ts文件的代码审查。请注意，这些评论仅针对代码质量和潜在问题，不包括其他方面的细节。
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
架构升级的部分功能实现
Other information
Summary by CodeRabbit
以下是这些拉取请求的简洁发布说明：
packages/@plugin/plugin-eslint/index.ts:
buildToolConfigs对象和一个pluginEslint函数，用于处理不同构建工具的配置。packages/core/src/index.ts:
createApp函数的调用，添加了一个console.log(pluginOptions, plugin)语句，并对代码进行了格式化调整。packages/core/src/utils/createAppTest.ts:
package.json文件，并使用PackageAPI类来管理package.json的操作。packages/core/src/utils/packageAPI.ts:
packageAPI的类，用于创建、读取、更新和删除package.json文件。请注意，这些发布说明侧重于对最终用户可见的功能，并省略了代码级别的细节。