Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FrontControllerLaunchOptions.ForceInProcess to support NCrunch #2947

Closed
bradwilson opened this issue Jun 9, 2024 · 1 comment
Closed

Comments

@bradwilson
Copy link
Member

bradwilson commented Jun 9, 2024

NCrunch wants to be able to load the test assembly in-process, even for v3 test projects (which are typically out of process). This flag would allow us to load the test assembly in-process, on the assumption that NCrunch is already setting up to do all the necessary dependency resolution.

I think I'm going to end up with a flag you can pass for launch options, per our previous discussion. Nothing's wired up yet, but this would be a base set of options that are available to all the front controller methods in v3 runner utility (Find, FindAndRun, and Run):

image

What it would do for v3 projects would be to load the .exe in-process and find the entry point, and then call it with all the correct arguments. I'm already constructing the argument list on behalf of the out-of-process invocation anyway. If user's customize the entry point, it'll end up calling them just like launching the executable would.

That's the theory, anyways. 🤞🏼

Discussion: #2337 (comment)

Edit: This issue has a dependency on #2951 being finished first.

@bradwilson bradwilson mentioned this issue Jun 9, 2024
@bradwilson bradwilson changed the title Add FrontControllerLaunchOptions.ForceInProcess to support NCrunch Add FrontControllerLaunchOptions.ForceInProcess to support NCrunch Jun 9, 2024
@bradwilson
Copy link
Member Author

Verified that we have provided NCrunch with everything they need for integration at this point. They can open new issues if they uncover specific problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant