Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search functionality #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrGoumX
Copy link

@MrGoumX MrGoumX commented Nov 5, 2020

PR Details

Improve tube search functionality.

Description

Add capability to peek at a specific job by ID and filter search results by specific state (ready, delayed, buried).

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #35 (4873a6c) into master (73d917a) will decrease coverage by 0.10%.
The diff coverage is 80.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   85.97%   85.87%   -0.11%     
==========================================
  Files          27       27              
  Lines        1690     1720      +30     
==========================================
+ Hits         1453     1477      +24     
- Misses        179      182       +3     
- Partials       58       61       +3     
Impacted Files Coverage Δ
lib.go 82.88% <77.77%> (-0.54%) ⬇️
handlers.go 93.47% <100.00%> (ø)
tplSearchTube.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d917a...4c1a64b. Read the comment docs.

@MrGoumX MrGoumX force-pushed the search_improvements branch 2 times, most recently from f8bd50a to 81c9cee Compare November 8, 2020 18:11
@MrGoumX MrGoumX marked this pull request as ready for review November 8, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant