Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Excelize to the master branch code #19

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

tianaiyouqing
Copy link
Contributor

Upgrade the Excelize to the master branch code and remove unused data types

PR Details

Upgrade the Excelize to the master branch code and remove unused data types

Description

Upgrade the Excelize to the master branch code and remove unused data types

Related Issue

N/A

Motivation and Context

Upgrade the Excelize to the master branch code and remove unused data types

How Has This Been Tested

Existing unit test are passed

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Update and remove unused data types
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 3, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a6a444) 98.44% compared to head (f8e0601) 98.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files           1        1           
  Lines        2951     2958    +7     
=======================================
+ Hits         2905     2912    +7     
  Misses         35       35           
  Partials       11       11           
Flag Coverage Δ
unittests 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit dd73586 into xuri:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants