Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Action configurations #26

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Update GitHub Action configurations #26

merged 1 commit into from
Jun 24, 2024

Conversation

zhangyimingdatiancai
Copy link
Contributor

PR Details

This PR updated GitHub Action configurations

Description

  • Update the Node.js version from 18 to 20 to resolve warning log in pipeline logs
  • Add double quote for Go language test's coverprofile flag for avoid codov can not find "coverage.txt" in Windows environments

Related Issue

N/A

Motivation and Context

Update outdate or deprecated Node.js version in the GitHub Action build an publish pipelines.

How Has This Been Tested

Check yml format by myselfs.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2024
xuri
xuri approved these changes Jun 24, 2024
View reviewed changes
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit c0e4e0c into xuri:main Jun 24, 2024
1 check passed
@zhangyimingdatiancai zhangyimingdatiancai deleted the gh-action branch August 26, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuri xuri xuri approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangyimingdatiancai @xuri