Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function GetMergeCells has been added #28

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

LogikMeister
Copy link
Contributor

@LogikMeister LogikMeister commented Jul 1, 2024

PR Details

  • A new function GetMergeCells has been added

Description

GetMergeCells provides a function to get merged cells from a specific worksheet.

Related Issue

None

Motivation and Context

Currently, the wasm package lacks the API to obtain the merged cells.

How Has This Been Tested

Add unit unit tests and existing test case passed

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2024
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I intentionally keep the function name same between the Web assembly port and Go language one, to let developer and maintainer be easy to find and maintain all APIs across multi language ports. Can we port GetMergeCells function and implement the interface GetStartAxis and GetEndAxis in TypeScript?

@LogikMeister
Copy link
Contributor Author

Thanks for your PR. I intentionally keep the function name same between the Web assembly port and Go language one, to let developer and maintainer be easy to find and maintain all APIs across multi language ports. Can we port GetMergeCells function and implement the interface GetStartAxis and GetEndAxis in TypeScript?

OK, I updated my PR as you suggested. You can check again.

@LogikMeister LogikMeister changed the title New function GetMergedRanges has been added New function GetMergeCells has been added Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (cf27ddf) to head (2aae962).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   98.80%   98.81%   +0.01%     
==========================================
  Files           1        1              
  Lines        2594     2627      +33     
==========================================
+ Hits         2563     2596      +33     
  Misses         21       21              
  Partials       10       10              
Flag Coverage Δ
unittests 98.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I added unit tests for exception case, format and simplify code based on your branch.

@xuri xuri merged commit 5dea100 into xuri:main Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants