-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New function GetMergeCells has been added #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I intentionally keep the function name same between the Web assembly port and Go language one, to let developer and maintainer be easy to find and maintain all APIs across multi language ports. Can we port GetMergeCells
function and implement the interface GetStartAxis
and GetEndAxis
in TypeScript?
OK, I updated my PR as you suggested. You can check again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 98.80% 98.81% +0.01%
==========================================
Files 1 1
Lines 2594 2627 +33
==========================================
+ Hits 2563 2596 +33
Misses 21 21
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I added unit tests for exception case, format and simplify code based on your branch.
PR Details
Description
GetMergeCells provides a function to get merged cells from a specific worksheet.
Related Issue
None
Motivation and Context
Currently, the wasm package lacks the API to obtain the merged cells.
How Has This Been Tested
Add unit unit tests and existing test case passed
Types of changes
Checklist