Don't set message and logger to null #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If message and logger are set to null, when JRebel reloads jersey resources, the Reporter is run again and there is a NullPointerException due to `message` (and `logger`) being null after the last time `report()` was called.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If message and logger are set to null, when JRebel (or other class reloading tool) reloads jersey resources, the Reporter is run again and there is a NullPointerException due to
message(andlogger) being null after the last timereport()was called.This patch removes the code that sets
loggerto null and assigns a new instance of StringBuilder tomessageinstead of setting it to null.Fixes #29