Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22040: Select tour step order has no name #3026

Merged
merged 1 commit into from
May 15, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Mar 27, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22040

Changes

Description

  • Paired the label with its select

Screenshots & Video

No visual changes

Executed Tests

Built change with mvn clean install -f xwiki-platform-core/xwiki-platform-tour/xwiki-platform-tour-ui.
Afterward successfully ran mvn clean install -f xwiki-platform-core/xwiki-platform-tour/xwiki-platform-tour-test/ -Pdocker,quality,integration-tests -Dxwiki.test.ui.wcag=true. There, no WCAG violation of the rule select-name were found.
Here is the content of the resulting wcagWarnings.txt file
We can see that the violations for which this issue were reported are not here anymore.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.x , pretty safe changes with a limited scope and coverage tests ran successfully.

* Paired the label with its select
Copy link
Contributor

@manuelleduc manuelleduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Note: you are missing the backport labels and the fix versions on the Jira issue ;)

@Sereza7 Sereza7 added the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label Mar 27, 2024
@surli surli merged commit 99e3b46 into xwiki:master May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants