Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22041: Image pasted during tests has no alternative #3027

Merged
merged 1 commit into from
May 15, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Mar 27, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22041

Changes

Description

  • Added an alt in the copied content

Clarifications

  • The image-alt WCAG violation happened when the viewpage where we copy the image was opened (during test setup). I updated the HTML to add an alt, and updated the result to match this change.
  • Now the assertion will fail if the alt is not kept through the pasting+editing process.

Screenshots & Video

None, development issue only

Executed Tests

Passed mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test -P docker,integration-tests,quality -Dxwiki.test.ui.wcag=true successfully. In the wcagWarnings, there is no image-alt rule violation anymore.
With the more specific mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test -P docker,integration-tests,quality -Dxwiki.test.ui.wcag=true -Dit.test=ImageIT#pasteAndEditExternalImage, there is no WCAG violation reported at all anymore.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.x , development only change, low scope of impact and not dangerous.

@surli surli added the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label May 15, 2024
@surli surli merged commit 772e2f1 into xwiki:master May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants