Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22037 AWM Display as hidden field should not be displayed #3043

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Josue-T
Copy link
Contributor

@Josue-T Josue-T commented Apr 4, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22037

Changes

Description

  • Add support to hidden type in Content and Title custom display
  • Factorise code between edit and hidden mode (by moving out of the if)

Clarifications

Executed Tests

It's mainly the same process than to reproduce the issue described here: https://jira.xwiki.org/browse/XWIKI-22037

Tested by creating a new App with AWM and edited the title1 and content1 field on the generated sheet to show as hidden. Than tested that theses field are correctly hidden.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • Ideally on 15.10.x

* Add support to hidden type in Content and Title custom display
* Factorize code between edit and hidden mode
* Put var assignation into 'if'
* Revert var name change
@Josue-T
Copy link
Contributor Author

Josue-T commented Apr 11, 2024

Hello,

Did the requested changes.

@Josue-T Josue-T requested a review from lucaa April 11, 2024 13:25
@Josue-T Josue-T requested a review from lucaa May 13, 2024 08:34
@Josue-T Josue-T requested a review from lucaa May 15, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants