Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandoc runs from bash working dir rather than $nb working dir -- fails to render resources #283

Closed
akashpal-21 opened this issue Oct 18, 2023 · 2 comments

Comments

@akashpal-21
Copy link

nb export [item] [path] fails to render resources (images) because pandoc is initiated from current bash working dir!
if I cd into $notebook and run the command it exports correctly.

Would it be possible to make nb export directory agnostic like the rest of the commands?

@akashpal-21 akashpal-21 reopened this Oct 18, 2023
xwmx added a commit that referenced this issue Feb 6, 2024
xwmx added a commit that referenced this issue Feb 8, 2024
@xwmx
Copy link
Owner

xwmx commented Feb 8, 2024

@akashpal-21 Thanks for the heads up! As of version 7.11.0, pandoc now runs in the directory containing the target item, and a test has been added confirming that images are embedded when using the pandoc --embed-resources or deprecated --self-contained options. By default, export does not embed the images. I can consider making --embed-resources / --self-contained the default if it makes sense.

@xwmx xwmx closed this as completed Feb 11, 2024
@akashpal-21
Copy link
Author

Thanks for fixing it, although I won't be able to take benefit of it currently - I have moved to using Emacs to keep my notes as vim didn't fit my need and once it was done I found myself not wanting to use the md format too;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants