Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run DB Install check in WP Admin and WP CLI #1286

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Conversation

tomjn
Copy link
Contributor

@tomjn tomjn commented Sep 16, 2021

Related to #1284

Check the tables exist to avoid problems when the normal activation mechanism isn't used, e.g. MU plugins.

This PR checks on WP Admin and WP CLI so as to avoid constantly checking on busy frontends or endpoints

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Describe a bug fix included in this release.
  • New: Describe a new feature in this release.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kasparsd kasparsd merged commit f541b74 into xwp:develop Sep 17, 2021
@kasparsd kasparsd mentioned this pull request Sep 17, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants