Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache api check #111

Merged
merged 11 commits into from
May 19, 2020
Merged

Cache api check #111

merged 11 commits into from
May 19, 2020

Conversation

spacedmonkey
Copy link
Contributor

Summary

Run request from send_request to cache results on api check.

Fixes UVP-210

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@derekherman
Copy link
Contributor

Why did coverage go down, does this not cover a condition in the new code?

@spacedmonkey
Copy link
Contributor Author

Why did coverage go down, does this not cover a condition in the new code?

Still a work in progress.

@spacedmonkey spacedmonkey changed the title [WIP] Cache api check Cache api check May 14, 2020
ravichdev
ravichdev previously approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@spacedmonkey
Copy link
Contributor Author

@ravichdev Can you review. I have tweaked this to reuse existing error message we have in the code base.

@ravichdev ravichdev self-requested a review May 19, 2020 10:18
ravichdev
ravichdev approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@spacedmonkey spacedmonkey merged commit 3ef01a2 into develop May 19, 2020
@spacedmonkey spacedmonkey deleted the fix/UVP-210 branch May 20, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravichdev ravichdev ravichdev approved these changes

@derekherman derekherman Awaiting requested review from derekherman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @derekherman @ravichdev