Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved design to auth flow #113

Merged
merged 16 commits into from
May 20, 2020
Merged

Improved design to auth flow #113

merged 16 commits into from
May 20, 2020

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey commented May 14, 2020 •
edited
Loading

Summary

Fixes UVP-204 UVP-205 UVP-206 UVP-207

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@spacedmonkey spacedmonkey changed the title [WIP] Improved auth flow Improved design to auth flow May 14, 2020
@pierlon pierlon requested review from ravichdev and removed request for pierlon May 14, 2020 19:18
ravichdev
ravichdev previously approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev changes look good to me, but there might be some wording changes based on our discussion on Slack.

ravichdev
ravichdev previously approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@derekherman derekherman merged commit b2fccc4 into develop May 20, 2020
@derekherman derekherman deleted the improved-auth-flow branch May 20, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravichdev ravichdev ravichdev left review comments

@derekherman derekherman Awaiting requested review from derekherman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @ravichdev @derekherman