Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override the details template. #156

Closed
wants to merge 7 commits into from
Closed

Override the details template. #156

wants to merge 7 commits into from

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey commented Jun 9, 2020 •
edited by ravichdev
Loading

Summary

Fixes #148 #151

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

spacedmonkey
spacedmonkey commented Jun 9, 2020
View reviewed changes
php/class-plugin.php
);

?>
<script type="text/html" id="tmpl-unsplash-attachment-details">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/WordPress/wordpress-develop/blob/8b9823f53621a63d0a47626920f6930f35db160c/src/wp-includes/media-template.php#L585-L693

ravichdev
ravichdev previously approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ravichdev ravichdev changed the title [WIP] Override the details template. Override the details template. Jun 11, 2020
@ravichdev ravichdev linked an issue Jun 11, 2020 that may be closed by this pull request
Update the Media Library's post-import Attachment Details shown to user #151
Closed
@ravichdev ravichdev closed this Jun 11, 2020
@ravichdev ravichdev removed a link to an issue Jun 11, 2020
Update the Media Library's post-import Attachment Details shown to user #151
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravichdev ravichdev ravichdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Media Selector's pre-import Attachment Details shown to user
2 participants
@spacedmonkey @ravichdev