Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore phpcs-js.xml #185

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Ignore phpcs-js.xml #185

merged 1 commit into from
Jun 30, 2020

Conversation

spacedmonkey
Copy link
Contributor

Summary

Ignore phpcs-js.xml on build.
Fixes #

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

ravichdev
ravichdev approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@spacedmonkey spacedmonkey merged commit 042066a into develop Jun 30, 2020
@derekherman derekherman deleted the fix/ignore-phpcs-js branch July 2, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravichdev ravichdev ravichdev approved these changes

@derekherman derekherman Awaiting requested review from derekherman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spacedmonkey @ravichdev