Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name sure site name isn't empty. #208

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Name sure site name isn't empty. #208

merged 3 commits into from
Aug 7, 2020

Conversation

spacedmonkey
Copy link
Contributor

Summary

If site name is empty, fallback to domain with dashes in it.

Fixes #

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

ravichdev
ravichdev suggested changes Aug 7, 2020
View reviewed changes
php/class-settings.php Outdated Show resolved Hide resolved
php/class-settings.php Show resolved Hide resolved
@spacedmonkey spacedmonkey added this to the 1.0.1 milestone Aug 7, 2020
@spacedmonkey spacedmonkey self-assigned this Aug 7, 2020
@spacedmonkey spacedmonkey added the bug Something isn't working label Aug 7, 2020
@spacedmonkey spacedmonkey merged commit 7a26345 into develop Aug 7, 2020
@spacedmonkey spacedmonkey deleted the fix/empty-name branch August 7, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravichdev ravichdev ravichdev approved these changes

@derekherman derekherman Awaiting requested review from derekherman

Assignees

@spacedmonkey spacedmonkey

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@spacedmonkey @ravichdev