Install PHP 5.6 compatible libraries #25
Conversation
There was a problem hiding this comment.
The way we handle this in the wp-foo-bar plugin is to load different versions of the packages based on the php version of the platform. The issue is that I'm not checking int he lock file cause I'm not sure that it would still work with both versions of PHP.
https://github.com/xwp/wp-foo-bar/blob/develop/composer.json#L12:L27
For now this solution works but I think generally we should migrate to the new scaffolding at some point soon as there are a lot of benefits in there other.
| @@ -148,13 +154,6 @@ public function test_get_item() { | |||
| 'color' => '#D9E8EF', | |||
| 'description' => '', | |||
| 'alt_description' => 'black motorcycle', | |||
| 'urls' => [ | |||
There was a problem hiding this comment.
@pierlon Why remove this?
There was a problem hiding this comment.
Recent Travis build failed because the urls returned from the Unsplash API were different, so I'm only checking to ensure that the image types in the urls array are returned.
I was thinking of testing the host part of the url for each but that seemed like overkill.
PHP 5.6 based Travis builds are failing due to PHP 7 libraries being installed. This should have been caught when doing
composer installbut platform requisites are being ignored.