Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with new test feature: Word Wise for EPUB books #53

Closed
Phobooky opened this issue Jul 28, 2022 · 9 comments
Closed

Problem with new test feature: Word Wise for EPUB books #53

Phobooky opened this issue Jul 28, 2022 · 9 comments

Comments

@Phobooky
Copy link

Phobooky commented Jul 28, 2022

Describe the bug

All Spanish books I've test are perfectly generated, by English books are bad generated. Many lines over the word without definition or repeated definitions.
I enclose examples.

System Information

OS: Windows 11
calibre version: Last one
Phyton version: Python 3.10.5
Plugin version: 3,24.0 (last in GitHub Actions right now)

Error message

No error message

Reproduce steps

  1. Generate epub with word wise

Screenshots or videos

1
2

@xxyzz
Copy link
Owner

xxyzz commented Jul 28, 2022

Some glosses are too long so I only add the footnotes.

The second pic is strange, could you upload the origin and the created book file?

@xxyzz
Copy link
Owner

xxyzz commented Jul 28, 2022

I see some words in the <ruby> tag also have <ruby> above them, maybe you somehow added Word Wise to a book then added again to the generated book?

@Phobooky
Copy link
Author

Have in mind that in the first one there are many blue underlined words without meaning. This does not happen in Spanish books.

Gabriel Allon 01 - The Kill Art - Daniel Silva_word_wise.zip

@Phobooky
Copy link
Author

image
This is a perfect one:

@Phobooky
Copy link
Author

As answer to:
I see some words in the tag also have above them, maybe you somehow added Word Wise to a book then added again to the generated book?
You're right. Let me check again, please.

@Phobooky
Copy link
Author

Phobooky commented Jul 28, 2022

Ok. It was my fault... but I don't understand why are there so many underlined words without meaning. The Spanish book is better related to this.
I mean... why are there a lot of words underlined (in blue) without tag?

image

@xxyzz
Copy link
Owner

xxyzz commented Jul 28, 2022

Because the gloss is too long, click one you'll see the long gloss.

The code for extracting short gloss from Wiktionary still need improvement, but it won't be easy...

@Phobooky
Copy link
Author

Wonderful!!! I'm very sorry. You can close the issue and I apologize.

@xxyzz
Copy link
Owner

xxyzz commented Jul 28, 2022

No need to apologize... Enjoy your books!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants