Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nullable columns #121

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Conversation

carlosefr
Copy link
Contributor

When a column has null values and non-null values (e.g. Nullable(Float64)), the non-null values were being returned as strings instead of their correct data type.

When a column has null values, the non-null values were being returned
as strings instead of their correct data type.
@coveralls
Copy link

coveralls commented Feb 9, 2021

Coverage Status

Coverage increased (+0.03%) to 95.545% when pulling b932b27 on carlosefr:handle_nullables into dce3dbb on xzkostyan:master.

@xzkostyan xzkostyan merged commit 230c6e7 into xzkostyan:master Feb 18, 2021
lance0805 pushed a commit to lance0805/clickhouse-sqlalchemy that referenced this pull request Sep 17, 2021
* Handle nullables correctly

When a column has null values, the non-null values were being returned
as strings instead of their correct data type.

* Also handle Decimal aliases

* Support bigger integer types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants