Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify issue #126

Merged
merged 3 commits into from
Mar 13, 2021
Merged

Fix verify issue #126

merged 3 commits into from
Mar 13, 2021

Conversation

yhvicey
Copy link
Contributor

@yhvicey yhvicey commented Mar 13, 2021

Verify from sqla connection string query will be of type str and requests will ignore it.

@xzkostyan
Copy link
Owner

It's better to use sqlalchemy.util.asbool.

@xzkostyan xzkostyan merged commit ee0a98a into xzkostyan:master Mar 13, 2021
@yhvicey
Copy link
Contributor Author

yhvicey commented Mar 14, 2021

Is there any release planned including this fix?

@xzkostyan
Copy link
Owner

Version 0.1.6 released.

lance0805 pushed a commit to lance0805/clickhouse-sqlalchemy that referenced this pull request Sep 17, 2021
@yhvicey @lance0805
Fix verify issue (xzkostyan#126)
eef82b8 
* Fix verify issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhvicey @xzkostyan @yiwwan