Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger events before and after drop table #246

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

vanchaxy
Copy link

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-driver.readthedocs.io/en/latest/development.html.

@vanchaxy
Copy link
Author

Can't manage to work alembic test suite, so only test for table.drop() added. op.drop_table() will emit events when used in migrations after these changes.

@coveralls
Copy link

Coverage Status

Coverage: 85.376% (-0.05%) from 85.431% when pulling d3eb7b9 on vanchaxy:master into bf3f3e8 on xzkostyan:master.

@xzkostyan xzkostyan merged commit 0417590 into xzkostyan:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The drop table operation does not trigger the before_drop and after_drop events
3 participants