Add native IPv4 and IPv6 types support #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. I'll review PR in a couple of weeks. I'm on vacation right now. |
xzkostyan
requested changes
Mar 31, 2019
clickhouse_sqlalchemy/types.py
Outdated
|
|
||
| def bind_processor(self, dialect): | ||
| def process(value): | ||
| return unicode(value) |
There was a problem hiding this comment.
There is compatible helper for this.
from .util import compat
return compat.text_type(text)There was a problem hiding this comment.
Oops didn't see it, fixed!
setup.py
Outdated
| install_requires = [ | ||
| 'sqlalchemy>=1.2', | ||
| 'requests', | ||
| 'clickhouse_driver>=0.0.14' |
There was a problem hiding this comment.
I've bumped clickhouse-driver version to 0.0.19 for ip addresses support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds IPv4 and IPv6 support in sqlalchemy, following the work done in clickhouse-driver.
Note that as no release of clickhouse-driver with IP support is available in pip yet, travis will fail for now. Nonetheless all tests are passing on my computer on python 3.6 and 2.7 (with clickhouse 19.3.3+).
I have also added the require_server_version decorator to be used in tests so IP related tests run only on 19.3.3+
Finally as clickhouse only support basic comparators for IP, I have added the in and not in operators to generate proper queries, see tests for examples.