simple delete implemented #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzkostyan
requested changes
Feb 15, 2020
There was a problem hiding this comment.
Please rebase to latest master.
Some really old servers can miss DELETE support. It was introduced in 1.1.54388.
It'll be really cool if we can check whether server supports it or not in following manner. server_version is filled on connection establishing.
self.supports_delete = self.server_version_info >= (1, 1, 54388)If we're dealing with old server CompileError should be raised in visit_delete.
|
|
||
| text += table_text + " DELETE" | ||
|
|
||
| if delete_stmt._whereclause is not None: |
There was a problem hiding this comment.
It seems that WHERE clause is required for delete:
:) alter table test delete;
Syntax error: failed at position 24 (end of query):
alter table test delete;
Expected WHEREIn case of no where exception should be raised: raise exc.CompileError('WHERE clause is required'). It's also be good to have test on this.
| from tests.testcase import BaseTestCase | ||
|
|
||
|
|
||
| class DeleteTestCase(BaseTestCase): |
There was a problem hiding this comment.
It's necessary to have also delete test for ORM case.
| from sqlalchemy import Column | ||
|
|
||
| from clickhouse_sqlalchemy import types, Table | ||
| # from tests.session import session |
|
Implemented. Thanks for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like that:
t1.delete().where(t1.c.x == 25)translates to
'ALTER TABLE t1 DELETE WHERE x = 25'