Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IP types #91

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Conversation

AchilleAsh
Copy link
Contributor

This improves the IP types support in 2 aspects:

  • add support for literal binds (was missing)
  • extensive implementation of IN and NOT IN comparators (compared to the primitive one currently in place)

The Comparator implementation is here to overcome the basic Clickhouse implementation for IP types by generating complex AND & OR combinations, but this has the advantage of covering a lot - if not all - cases (see tests).

As the IPv4 and IPv6 comparators have exactly the same behavior, I've extracted a common base implementation to keep it clean.

All the required tests are added.

@coveralls
Copy link

coveralls commented Mar 22, 2020

Coverage Status

Coverage increased (+0.1%) to 95.086% when pulling a3bf945 on AchilleAsh:improve_ip_support into eb6b5e8 on xzkostyan:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 95.089% when pulling ff3a4dd on AchilleAsh:improve_ip_support into eb6b5e8 on xzkostyan:master.

@xzkostyan xzkostyan merged commit 0ab5093 into xzkostyan:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants