Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if_exists and on_cluster AttributeError-s #94

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

vmarkovtsev
Copy link
Contributor

@vmarkovtsev vmarkovtsev commented Apr 27, 2020

This PR makes the following code execute without errors:

import sqlalchemy
import clickhouse_sqlalchemy.engines

metadata = sqlalchemy.MetaData()

notes = sqlalchemy.Table(
    "notes",
    metadata,
    sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
    sqlalchemy.Column("text", sqlalchemy.String(length=100)),
    clickhouse_sqlalchemy.engines.Memory(),
)

engine = sqlalchemy.create_engine("clickhouse://default:@0.0.0.0:8123")
metadata.create_all(engine)
metadata.drop_all(engine)

Related to #22

Can you please make a new PyPI release after merging this.

@coveralls
Copy link

coveralls commented Apr 27, 2020

Coverage Status

Coverage remained the same at 95.226% when pulling 2b20f32 on vmarkovtsev:fix-drop into f3df5f8 on xzkostyan:master.

@xzkostyan xzkostyan merged commit 91d04c5 into xzkostyan:master Apr 30, 2020
@xzkostyan
Copy link
Owner

Sure. Version 0.1.4 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants