Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stuff #15

Closed
wants to merge 3 commits into from
Closed

Fixed stuff #15

wants to merge 3 commits into from

Conversation

pineapplemachine
Copy link
Contributor

Make inkjs great again

@y-lohse
Copy link
Owner

y-lohse commented Jul 4, 2016

Fantastic, thank you. I'm just going to try and reproduce the sb bug before I merge these, as I've used similar structures elsewhere.

@joethephish
Copy link
Contributor

Yeah, I think the string building code was fine as it was...?

image

@y-lohse
Copy link
Owner

y-lohse commented Jul 4, 2016

Just took a quick look at it, I can reproduce the problem, but 854d29d doese'nt appear to fix it. I've created a separate issue to deal with that one (#17).

@pineapplemachine can you maybe remove commit 854d29d from this PR so I can already merge the other one? If not I can probably cherry pick but I've never done that befor,e so I may fuck it up ^.^

@pineapplemachine
Copy link
Contributor Author

Oh, the second commit was me being too hasty. Obviously going from a += b to a = a + b isn't going to change anything. Should be a = b + a. Committing a fix.

That was a dumb mistake
@y-lohse
Copy link
Owner

y-lohse commented Jul 4, 2016

I cherry picked the typo fix, so closing this PR now.

@y-lohse y-lohse closed this Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants