Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Dragging on the timeline is disabled when elements such as text or images are selected. #358

Closed
junhaoliao opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@junhaoliao
Copy link
Collaborator

junhaoliao commented Apr 16, 2024

Bug

Internal trials of the WebUI timeline has found that occasionally the timeline shows a "disabled" cursor when users drag on the timeline for zooming into a time range selection.

CLP version

2b55f93

Environment

Built with Ubuntu 22.04
Ran with official execution container

Reproduction steps

Through issue reproduction, it was determined that users might have unintentionally selected some text or empty element when they first attempt dragging on a region outside of the timeline chart. Then any further attempts to drag on the chart would also fail because those would be consider dropping the selection onto the chart, which is an undefined behaviour. As a result, the browser shows a "disabled" cursor which also impacted the chart's mousemove listener.

Reproduction video

  1. NOTE: before dragging on the timeline, the mouse double-clicked outside of the chart region, which selected some empty element.
    https://github.com/y-scope/clp/assets/43196707/3e49dff7-a6ea-49cf-a377-714dda25de05
  2. https://github.com/y-scope/clp/assets/43196707/4d95dfb4-1f18-4066-aca1-4502d307e3b3
@junhaoliao junhaoliao added the bug Something isn't working label Apr 16, 2024
@junhaoliao junhaoliao self-assigned this Apr 16, 2024
junhaoliao added a commit that referenced this issue Apr 24, 2024
…xes #358). (#359)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants