Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow an empty log type (fixes #75). #76

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Allow an empty log type (fixes #75). #76

merged 1 commit into from
Aug 25, 2022

Conversation

kirkrodrigues
Copy link
Member

References

#75

Description

Removed the check which prevents compressing messages with just a timestamp and no content.

Validation performed

  • Validated compressing and decompressing logs including those containing messages with no content.
  • Validated searching the same logs.

@kirkrodrigues kirkrodrigues changed the title Allow an empty log type. Allow an empty log type (fixes #75). Aug 25, 2022
@davidlion davidlion merged commit 5593252 into y-scope:main Aug 25, 2022
@kirkrodrigues kirkrodrigues deleted the fix-75 branch August 25, 2022 19:45
davidlion pushed a commit to SharafMohamed/clp that referenced this pull request Sep 1, 2022
port of 5593252 [upstream/main] Allow an empty log type. (y-scope#76)
5324e5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlion davidlion davidlion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkrodrigues @davidlion