This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
Replace 15s interval, 15m threshold with statistical formula. #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #96.
Yesterday I took a long walk with this changed version of Trackbook and was happy with the results. The points were recorded about twice as frequently as normal without decreasing the track quality or rest detection.
Note!! In the future, I think we should modify
isAccurateEnough
to increase the confidence that we are below the user's set threshold. Like this:However, I did not do that in this pull request because any user who has already tuned their accuracy threshold setting will suddenly find that their tracks are recording fewer points after updating. Increasing confidence decreases tracking interval. I don't want to make that change without further careful consideration. Likewise, we can do
accuracyDelta * 2
(or even just 1.5, etc.) if we want to increase the confidence in distance deltas.One more note: If we're going to keep the waypoint interval at 1s, perhaps we should merge that function with MapFragment.kt's
periodicLocationRequestRunnable
which also runs at 1s. At the moment, this pull request keeps them as separate timers, which is probably a bit wasteful.Thank you @y20k and @Hob111.