Bug fixes, framerate cap mode #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqiri
reviewed
Sep 18, 2023
window.lua
Outdated
| local fileInfo = love.filesystem.getInfo(WINDOW_FILE) | ||
| if fileInfo then | ||
| local contents = love.filesystem.read(WINDOW_FILE) | ||
| local windowArr = String.split(contents, ',') |
There was a problem hiding this comment.
Probably won't need to trim given no-one in their right mind would modify this. But you could if someone is outside of their mind.
There was a problem hiding this comment.
It's coded into my brain now.
dqiri
reviewed
Sep 18, 2023
window.lua
Outdated
Comment on lines
13
to
15
| local x = windowArr[1] | ||
| local y = windowArr[2] | ||
| local display = windowArr[3] |
There was a problem hiding this comment.
oob check? or just fail? not sure if it could fail gracefully if someone did faff with the file.
There was a problem hiding this comment.
I believe they'd be nil, which would probably work with the setWindow function? Like it would use some default instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F7) that sets a maximum framerate of 120fps and a delta timestemp of 15ms.ticklibrary